[Differential] [Commented On] D4110: Quick open: support also line number notions "#Lll", "#nll", "#ll"

[Kevin Funk]

kfunk added inline comments.

INLINE COMMENTS

> kfunk wrote in texteditorhelpers.cpp:61
> Code looks a bit too branchy.
> 
> Maybe it'd make more sense if you'd just use on instance of QRegularExpressionMatch?
> 
>   auto match = pattern.match(input);
>   if (!match.hasMatch()) {
>       match2 = pattern.match(input);
>   }
>   
>   // ... as before
> 
> For `pattern2` `match.captured(2).toInt()` will always return 0, which should be handled fine by the original code.

Meant `match = pattern2.match(input);` in line 3 of course...

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4110

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170113/1e7674e9/attachment-0001.html>