[Differential] [Commented On] D4098: Clang: Also rename destructors when renaming class

[Aleix Pol Gonzalez]

apol added a comment.


  Obviously this was nitpicking. Clearly fixes a bug and it's tested.
  +1

INLINE COMMENTS

> test_refactoring.cpp:73
> +{
> +    const auto code = R"(
> +class Foo {

Wouldn't it be better for the tests to have separate `before.cpp` and `after.cpp` files?

Then we could do things like:

  action before.cpp > generated.cpp
  diff generated.cpp after.cpp

> test_refactoring.h:21
>  
> -#ifndef SIMPLEREFACTORING_H
> -#define SIMPLEREFACTORING_H
> -
> -#include "clangprivateexport.h"
> +#ifndef REFACTORINGTEST_H
> +#define REFACTORINGTEST_H

`TESTREFACTORING_H`?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D4098

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #kdevelop
Cc: apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170112/fc5c289d/attachment-0001.html>