[Differential] [Commented On] D3673: Outline: Sorted function list
brauch (Sven Brauch)
noreply at phabricator.kde.org
Fri Jan 6 01:37:22 UTC 2017
brauch added a comment.
Hmm, quite a diff :D
I have read through it, what I've seen looks sensible except the two places I commented. I think it's ok to put it into master now, and see if it breaks...
> + Q_ASSERT(eModel);
> + const QModelIndex sourceIndex = eModel->mapToSource(index);
> + if( eModel && eModel->isPartiallyExpanded( sourceIndex ) != ExpandingWidgetModel::ExpansionType::NotExpanded)
This makes no sense, first you deference it and then you have a check below
> + Q_UNUSED(index);
> return true;
To: kfunk, brauch, #kdevelop, nellex
Cc: kdevelop-devel, brauch, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel