[Differential] [Commented On] D3673: Outline: Sorted function list

[brauch (Sven Brauch)]

brauch added a comment.


  Hmm, quite a diff :D
  I have read through it, what I've seen looks sensible except the two places I commented. I think it's ok to put it into master now, and see if it breaks...

INLINE COMMENTS

> expandingtree.cpp:45
> +  Q_ASSERT(eModel);
> +  const QModelIndex sourceIndex = eModel->mapToSource(index);
> +  if( eModel && eModel->isPartiallyExpanded( sourceIndex ) != ExpandingWidgetModel::ExpansionType::NotExpanded)

This makes no sense, first you deference it and then you have a check below

> quickopenmodel.cpp:425
> +  Q_UNUSED(index);
>    return true;
>  }

huh :D

REPOSITORY
  R33 KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3673

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, brauch, #kdevelop, nellex
Cc: kdevelop-devel, brauch, #kdevelop, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170106/3f86ee25/attachment.html>