Review Request 129766: Fix yymore_used_but_not_detected undefined issue

[Kevin Funk]

> On Jan. 4, 2017, 11:59 a.m., Kevin Funk wrote:
> > Could you add the complete compile error you got earlier?
> > 
> > Adding `--yymore` doesn't yield a difference in the generated code for kdev-pg-lexer.cc here.
> 
> Leslie Zhai wrote:
>     Hi Kevin,
>     
>     Thanks for your reply!
>     
>     Please have a look at https://bugs.kde.org/show_bug.cgi?id=374523#c1 about Error?‘yymore_used_but_not_detected’ undefined
>     I am using flex-2.6.3 because 2.6.2 breaks kservice https://github.com/westes/flex/issues/134
>     
>     Regards,
>     Leslie Zhai

Okay, thanks for the links. That makes more sense to me now.

I've checked with flex-2.6.1. It already accepts --yymore (silently), too => we can probably use --yymore unconditionally just fine.

Will push.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129766/#review101783
-----------------------------------------------------------


On Jan. 4, 2017, 3:32 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129766/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 3:32 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 374523
>     http://bugs.kde.org/show_bug.cgi?id=374523
> 
> 
> Repository: kdevelop-pg-qt
> 
> 
> Description
> -------
> 
> flex-2.6.3 failed to 
> 
> ```
> #define yymore() yymore_used_but_not_detected
> ```
> 
> throw yymore_used_but_not_detected undefined issue, so I simply added --yymore option for CMakeLists.txt
> 
> 
> Diffs
> -----
> 
>   kdev-pg/CMakeLists.txt 5490835 
> 
> Diff: https://git.reviewboard.kde.org/r/129766/diff/
> 
> 
> Testing
> -------
> 
> built for kdevelop-pg-qt git master
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170105/fb237fc6/attachment.html>