[Differential] [Requested Changes To] D3970: Bug 368311: Add a new warning during fetching git repo

[kfunk (Kevin Funk)]

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> projectsourcepage.cpp:226
>                         (m_providerWidget && m_providerWidget->isCorrect()));
>      bool validToCheckout = correct && validWidget; //To checkout, if it exists, it should be an empty dir
>      if (validToCheckout && cwd.isLocalFile() && dir.exists()) {

Same here, fwiw. Could you change that as well?

> projectsourcepage.cpp:231
>  
> +    bool isFolderEmpty = false;
> +    if(correct && cwd.isLocalFile() && dir.exists())

Could be initialized properly in one expression (no need for another if-statement)

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3970

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: nellex, #kdevelop, kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170104/535ed95d/attachment.html>