Review Request 129768: Fix segfault when analyzing source code with clang-tidy

[Kevin Funk]

> On Jan. 4, 2017, 11:19 a.m., Kevin Funk wrote:
> > Let's add another opinion:
> > 
> > First of all: We should make it possible to use clang-tidy without a build system at all. clang-tidy is *usually* in combination with a CMake compilation database, but it is as well usable standalone. E.g you can write:
> > 
> > ```
> > $ clang-tidy test.cpp -- -Imy_project/include -DMY_DEFINES ...
> > ```
> > 
> > (cf. http://clang.llvm.org/extra/clang-tidy)
> > 
> > => If there's no BSM, I just wouldn't set the build dir on `params`. 
> > 
> > Please test whether clang-tidy actually works without BSM then.
> 
> Aleix Pol Gonzalez wrote:
>     So who provides the -I and -D attributes? a config dialog?

As a last resort: Right-click project -> Clang-Tidy -> Extra Parameters.

It's there.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129768/#review101782
-----------------------------------------------------------


On Jan. 4, 2017, 6:53 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129768/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 6:53 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 374525
>     https://bugs.kde.org/show_bug.cgi?id=374525
> 
> 
> Repository: kdev-clang-tidy
> 
> 
> Description
> -------
> 
> Hi KDevelop developers,
> 
> KDevelop segfault when analyzing source code with clang-tidy, so I simply added ```if (!buildSystem)``` check
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   src/plugin.cpp 0def66e 
> 
> Diff: https://git.reviewboard.kde.org/r/129768/diff/
> 
> 
> Testing
> -------
> 
> Analyzed K3B with clang-tidy
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170104/1cf9daa7/attachment.html>