Review Request 129767: Fix segfault when analyzing source code issue

[Francis Herne]

> On Jan. 4, 2017, 9:57 a.m., Sven Brauch wrote:
> > Looks ok to me in general, I think there are valid cases where buildSystemManager is null. Can you elaborate though under which circumstances this crash can be triggered?

It can be reproduced when the Generic Project Manager is used for a project, either by "Analyze -> Cppcheck..." or "Open Configuration" (same failure in both cases).


- Francis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129767/#review101778
-----------------------------------------------------------


On Jan. 4, 2017, 6:42 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129767/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 6:42 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 374525
>     http://bugs.kde.org/show_bug.cgi?id=374525
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Hi KDevelop developers,
> 
> ```
> Thread 1 "kdevelop" received signal SIGSEGV, Segmentation fault.
> 0x00007fffbbde43de in cppcheck::Parameters::Parameters (this=0x7fffffffa870, project=0x192f730)
>     at /data/project/kde/kdevelop/analyzers/cppcheck/parameters.cpp:110
> 110         m_projectBuildPath   = m_project->buildSystemManager()->buildDirectory(m_project->projectItem());
> ```
> 
> so I simply added ```if (m_project->buildSystemManager())``` check before calling ```m_project->buildSystemManager()->buildDirectory(...)```
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   analyzers/cppcheck/parameters.cpp ad1e7a02c3 
> 
> Diff: https://git.reviewboard.kde.org/r/129767/diff/
> 
> 
> Testing
> -------
> 
> Parsing K3B's souce code
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170104/250d303d/attachment.html>