Review Request 129768: Fix segfault when analyzing source code with clang-tidy

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129768/#review101780
-----------------------------------------------------------




src/plugin.cpp (line 202)
<https://git.reviewboard.kde.org/r/129768/#comment68129>

    Can you maybe show the error message on the toolview instead of a message box? It's never nice to get these, especially considering it's just a message, there's no interaction required.


- Aleix Pol Gonzalez


On Jan. 4, 2017, 7:53 a.m., Leslie Zhai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129768/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 7:53 a.m.)
> 
> 
> Review request for KDevelop and Kevin Funk.
> 
> 
> Bugs: 374525
>     https://bugs.kde.org/show_bug.cgi?id=374525
> 
> 
> Repository: kdev-clang-tidy
> 
> 
> Description
> -------
> 
> Hi KDevelop developers,
> 
> KDevelop segfault when analyzing source code with clang-tidy, so I simply added ```if (!buildSystem)``` check
> 
> Regards,
> Leslie Zhai
> 
> 
> Diffs
> -----
> 
>   src/plugin.cpp 0def66e 
> 
> Diff: https://git.reviewboard.kde.org/r/129768/diff/
> 
> 
> Testing
> -------
> 
> Analyzed K3B with clang-tidy
> 
> 
> Thanks,
> 
> Leslie Zhai
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170104/5e6b828e/attachment.html>