[Differential] [Commented On] D4776: support for $this as an array when implementing ArrayAccess
Alexander Zhigalin
noreply at phabricator.kde.org
Tue Feb 28 22:19:20 UTC 2017
zhigalin added inline comments.
INLINE COMMENTS
> duchain.cpp:2960
> +{
> + QByteArray method("<?php\n"
> + " class SHASHWAT extends \\ArrayAccess\n"
Just prepend arrayaccess here
> duchain.cpp:2989
> + // missing functions from \ArrayAccess and not declared abstract
> + QByteArray method("<?php\n"
> + " class A\n"
Just prepend arrayaccess here
> duchain.cpp:2990
> + QByteArray method("<?php\n"
> + " class A\n"
> + " {\n"
class A implements ArrayAccess
> zhigalin wrote in duchaintestbase.cpp:72
> unrelated; remove
Not a good idea to copy paste here stuff from php standard library
REPOSITORY
R52 KDevelop: PHP Support
REVISION DETAIL
https://phabricator.kde.org/D4776
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: shashwatdixit, #kdevelop, mwolff, zhigalin, kfunk
Cc: kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170228/f74af476/attachment.html>
More information about the KDevelop-devel
mailing list