[Differential] [Commented On] D4776: support for $this as an array when implementing ArrayAccess

[Alexander Zhigalin]

zhigalin added a comment.


  Rest LGTM

INLINE COMMENTS

> duchain.cpp:2961
> +    QByteArray method("<?php\n"
> +                      "  class SHASHWAT extends \\ArrayAccess\n"
> +                      "  {\n"

implements

> duchain.cpp:2970-2972
> +                      "  $test = new SHASHWAT;\n"
> +                      "  $test->setTest();\n"
> +                      "  echo $test['test'];\n");

no need

> duchain.cpp:2994-2996
> +                      "  $test = new A;\n"
> +                      "  $test->setTest();\n"
> +                      "  echo $test['test'];\n");

no need

> duchaintestbase.cpp:72
>      content.append("interface Iterator { function rewind(); function current(); function key(); function next(); function valid(); } ");
> +    content.append("interface ArrayAccess { function offsetExists($offset); function offsetGet($offset); function offsetSet($offset, $value); function offsetUnset($offset); }");
>      QVERIFY(!internalFunctionFile().isEmpty());

unrelated; remove

REPOSITORY
  R52 KDevelop: PHP Support

REVISION DETAIL
  https://phabricator.kde.org/D4776

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: shashwatdixit, #kdevelop, mwolff, zhigalin, kfunk
Cc: kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170228/7d707fd0/attachment.html>