[Differential] [Accepted] D4822: Adapt to API change: EnvironmentGroupList -> EnvironmentProfileList

Kevin Funk noreply at phabricator.kde.org
Mon Feb 27 15:55:48 UTC 2017


kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM

INLINE COMMENTS

> executeplugin.cpp:54
>  QString ExecutePlugin::isExecutableEntry = QStringLiteral("isExecutable");
> -QString ExecutePlugin::environmentGroupEntry = QStringLiteral("EnvironmentGroup");
> +QString ExecutePlugin::environmentProfileEntry = QStringLiteral("EnvironmentProfile");
>  QString ExecutePlugin::useTerminalEntry = QStringLiteral("Use External Terminal");

The value stayed at `QStringLiteral("EnvironmentGroup");` in kdevplatform. Please do the same here.

REPOSITORY
  R185 KDevelop Plugin: Embedded Platforms

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4822

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: zhigalin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170227/28ca37f7/attachment.html>


More information about the KDevelop-devel mailing list