[Differential] [Requested Changes] D4808: Find/Replace in files: fix tooltip omitting the matched text in Find mode

[Kevin Funk]

kfunk requested changes to this revision.
kfunk added a comment.
This revision now requires changes to proceed.


  Rest LGTM

INLINE COMMENTS

> grepoutputmodel.cpp:153
> +        // show replaced version in tooltip if we are in replace mode
> +        const QString match = isCheckable() ? grepModel->replacementFor(m_change->m_oldText) : m_change->m_oldText;
> +        const QString repl  = QLatin1String("<b>") + match.toHtmlEscaped() + QLatin1String("</b>");

Shouldn't this be `isChecked()` (doesn't exist, I know).

What exactly does this try to fix if not?

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4808

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170227/e7f13198/attachment.html>