[Differential] [Accepted] D4815: Attach-to-process dialog: add "Cancel" button, relabel "Ok" to "Attach"

[Francis Herne]

flherne accepted this revision.
flherne added a comment.
This revision is now accepted and ready to land.


  Makes sense.
  
  There's actually a pre-existing crashybug here, but not directly related to the patch; if you don't feel like fixing it I'll try in a few days.

INLINE COMMENTS

> processselection.cpp:98
>  {
> -    m_okButton->setEnabled(true);
> +    m_attachButton->setEnabled(true);
>  }

This can happen when unsetting the selection (ctrl-click on the selected row).
Leaving the button enabled in this case causes KDevelop to crash when it's clicked.

(not introduced by you, I just thought "wait a moment..." and tried it)

REPOSITORY
  R32 KDevelop

BRANCH
  buttonsForAttachProcessDialog

REVISION DETAIL
  https://phabricator.kde.org/D4815

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, flherne
Cc: flherne, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170226/0d97ed75/attachment.html>