[Differential] [Request, 9 lines] D4771: plugins/git: Set job error before emitResult()

Alexander Potashev noreply at phabricator.kde.org
Fri Feb 24 18:55:49 UTC 2017


aspotashev created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  GitPlugin::copy()->exec() did always return true, even on failure.

TEST PLAN
  Copy-paste files/folders inside a Git root without write permissions on the destination folder is expected to fail. ProjectManagerViewPlugin::pasteFromContextMenu() will display a warning dialog in this case.

REPOSITORY
  R33 KDevPlatform

BRANCH
  fix-gitplugin-errors

REVISION DETAIL
  https://phabricator.kde.org/D4771

AFFECTED FILES
  plugins/git/gitplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aspotashev, mwolff, kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170224/4275f55c/attachment.html>


More information about the KDevelop-devel mailing list