[Differential] [Commented On] D4730: Environment variables editor: dump editable combobox, use extra name editor

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Thanks for quick review, @apol  and @kfunk.
  
  BTW, there are still some more glitches in that dialog when it comes to variable editing, but I leave that for a later time/someone more eager to fix it now. I first would have to use this dialog some more to get a better idea what some typical workflows are.

INLINE COMMENTS

> kfunk wrote in environmentprofilelistmodel.h:25
> Note: `EnvironmentGroupList` should be renamed as well (can be done in another commit).

Agreed, that is also the plan (cmp. also my first own comment). Patch for review coming soon to a web service near you :)

REPOSITORY
  R33 KDevPlatform

BRANCH
  nomoreeditcomboboxforenvvareditor

REVISION DETAIL
  https://phabricator.kde.org/D4730

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop, apol, kfunk
Cc: kfunk, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170223/9560ed96/attachment.html>