[Differential] [Commented On] D4721: Improve the Qt5 QtQuick template and make it available in CMake as well

[Kevin Funk]

kfunk added inline comments.

INLINE COMMENTS

> CMakeLists.txt:6
> +qt5_add_resources(%{PROJECTDIRNAME}_SRCS resources.qrc)
> +add_executable(%{PROJECTDIRNAME} src/main.cpp ${%{PROJECTDIRNAME}_SRCS})
> +target_link_libraries(%{PROJECTDIRNAME} Qt5::Qml Qt5::Gui)

All the other templates in app_templates/ use `APPNAMELC` here. Looks like the better choice, considering that you could have a whitespace char in the dir name?

> CMakeLists.txt:9
> +
> +

Minor: Remove extra newlines

> main.qml:12
> +        anchors.fill: parent
> +        color: "steelblue"
>      }

Why no `Text{}` element at least? Now that's a boring example you have here!

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D4721

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, kfunk, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170223/28ad062b/attachment.html>