[Differential] [Requested Changes] D4672: Initial support for hookup of projects with general (web) services
Milian Wolff
noreply at phabricator.kde.org
Tue Feb 21 22:33:33 UTC 2017
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
Tons of new files and not a single test? Can you add some?
I don't have the time to review all the files, but some remarks from looking at the images and reading your commit message:
- what other things do you want to integrate?
- i.e. for the current feature of getting a remote link to the current file this sounds like overkill
In general, what do you plan to use this for? I mean the joy of git is that it's distributed. When would I ever need to go to the remote website for the current file? I can simply checkout a branch locally and look at that, no?
REPOSITORY
R33 KDevPlatform
REVISION DETAIL
https://phabricator.kde.org/D4672
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kossebau, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170221/bba532a5/attachment-0001.html>
More information about the KDevelop-devel
mailing list