[Differential] [Commented On] D4665: Fix project tree state not being saved

Milian Wolff noreply at phabricator.kde.org
Tue Feb 21 10:15:27 UTC 2017


mwolff added a comment.


  In https://phabricator.kde.org/D4665#88183, @flherne wrote:
  
  > There's not really any point nagging about the style further, when the existing document is totally inconsistent already.
  >
  > The actual changes look ok to me, and presumably to kfunk if he's also down to whitespace issues... go ahead ;-)
  
  
  +1, I only looked at the visible context shown by phabricator, and there no spaces where added. We really need to run clang-format on kdev* and introduce a hook to ensure no new violations of the style take place...

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4665

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bevendorff, apol, kfunk, mwolff, flherne
Cc: flherne, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170221/44c48fb5/attachment.html>


More information about the KDevelop-devel mailing list