[Differential] [Requested Changes] D4665: Fix project tree state not being saved

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  some nitpicks from my side, otherwise this looks good to me

INLINE COMMENTS

> projecttreeview.cpp:297
>  {
> -    QList<KDevelop::ProjectBaseItem*> itemlist;
> +    if ( project == m_previousSelection )
> +        m_previousSelection = nullptr;

add braces, remove spaces inside `()`, also below

> projecttreeview.cpp:302
> +
> +QList<ProjectBaseItem*> ProjectTreeView::getSelectedProjects()
> +{

remove `get` prefix, also below

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4665

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: bevendorff, mwolff, apol, kfunk
Cc: flherne, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170220/df5518cb/attachment.html>