[Differential] [Accepted] D4682: Customizable tooltip for "Force Full Update" action in the Problems View

[Kevin Funk]

kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Rest LGTM, thanks!

INLINE COMMENTS

> problemmodel.cpp:245
> +{
> +    bool changed = (d->m_fullUpdateTooltip != tooltip);
> +    d->m_fullUpdateTooltip = tooltip;

The pattern is usually:

  if (d->m_foo == foo) 
      return;
  
  d->m_foo = foo;
  emit fooChanged()

REPOSITORY
  R33 KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4682

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170220/6c236dff/attachment.html>