[Differential] [Requested Changes] D3627: Investigate warnings and fix them [2]

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  please use Q_ASSERT, otherwise lgtm

INLINE COMMENTS

> codecompletionhelper.cpp:53
> +  if( !view )
> +    return;
> +

I think this can simply be removed, view will always be valid. you could make it a `Q_ASSERT`

> duchainutils.cpp:164
>  
>    if( (p & CodeCompletionModel::Variable) )
>      if( (p & CodeCompletionModel::Protected) )

someone needs to add proper braces to this fugly function (separate patch)

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D3627

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Sergobot, kfunk, ematirov, mwolff
Cc: mwolff, ematirov, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170218/523b64b5/attachment.html>