[Differential] [Accepted] D4095: Refactor to embrace a cmake server import backend

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.


  minor nitpicks, otherwise lgtm
  
  please fix those and then feel free to commit

INLINE COMMENTS

> cmakemanager.cpp:195
> +
> +    QPointer<CMakeServer> server = nullptr;
> +    QPointer<IProject> project = nullptr;

these shouldn't be QPointer, or?

> cmakeserverimportjob.cpp:71
> +
> +    for(const QJsonValue& defineValue: defines) {
> +        const QString define = defineValue.toString();

space after for

> cmakeserverimportjob.cpp:74
> +        const int eqIdx = define.indexOf(QLatin1Char('='));
> +        if (eqIdx<0)
> +            ret[define] = QString();

add braces and spaces around operator

> cmakeserverimportjob.cpp:147
> +        qCDebug(CMAKE) << "replying..." << inReplyTo;
> +        if (inReplyTo == QLatin1String("handshake"))
> +            m_server->configure({});

add braces to all conditionals here

> cmakeserverimportjob.cpp:156
> +            emitResult();
> +        } else
> +            qWarning() << "unhandled reply" << response;

braces

> test_cmakeserver.cpp:29
> +{
> +Q_OBJECT
> +private slots:

indent

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D4095

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, kfunk, mwolff, #kdevelop
Cc: mwolff, antonanikin, arrowdodger, kfunk, kdevelop-devel, Pilzschaf, akshaydeo, surgenight
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170218/51d6b566/attachment.html>