[Differential] [Accepted] D4123: Show shortcuts on the tooltips.

Milian Wolff noreply at phabricator.kde.org
Wed Feb 15 22:11:33 UTC 2017


mwolff accepted this revision.
mwolff added a comment.


  if possible, remove the foreach. otherwise lgtm

INLINE COMMENTS

> mainwindow.cpp:401
> +
> +    foreach(QAction *action, actionCollection()->actions()) {
> +        QString tooltip = action->property(ORIGINAL_TOOLTIP).toString();

don't use foreach in new code please (use range-based for)

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D4123

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: tcanabrava, apol, antonanikin, kfunk, #kdevelop, mwolff
Cc: mwolff, antonanikin, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170215/66837b01/attachment.html>


More information about the KDevelop-devel mailing list