[Differential] [Request, 5 lines] D4598: Fix BUG 374894 - KDevelop crashes when clicking on QuickOpen

Mon Feb 13 15:09:31 UTC 2017

antonanikin created this revision.
antonanikin added reviewers: KDevelop, kfunk.
antonanikin added a subscriber: kdevelop-devel.

REVISION SUMMARY
  The problem was in not initialized field `m_result` in the `ResultCache` class. This leads to regularly return this uninitialized ("random") value from the `ProjectItemDataProvider::itemCount` method. The crash happens only if `ResultCache::m_result` value was sufficiently big and `ResultCache::markDirty` was not called before.

TEST PLAN
  Tested on master branch

REPOSITORY
  R33 KDevPlatform

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4598

AFFECTED FILES
  plugins/quickopen/projectitemquickopen.cpp
  plugins/quickopen/projectitemquickopen.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170213/4307bc95/attachment-0001.html>