[Differential] [Request, 79 lines] D4581: Launch config dialog: use standard button text Add/Remove, use QPushButton

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Feb 12 00:38:44 UTC 2017


kossebau created this revision.
kossebau added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Old text "Add New..." and "Remove Selected" were not following standard
  naming of such buttons in KDevelop, also could result in longer translations
  making the row minimum width quite large.
  The "..." also indicates another dialog usually, not just a popup list.
  Instead a popup indicator arrow is now used as in similar places.
  
  These Add/Remove buttons usually are also below or to the right of the
  object, not above. But moving below the list made the whole dialog
  look more strange, so not done here, needs a bigger overhaul of the
  whole dialog.

REPOSITORY
  R33 KDevPlatform

BRANCH
  useStandardAddRemovePushButton

REVISION DETAIL
  https://phabricator.kde.org/D4581

AFFECTED FILES
  shell/launchconfigurationdialog.cpp
  shell/launchconfigurationdialog.ui

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170212/9c45ecad/attachment.html>


More information about the KDevelop-devel mailing list