[Differential] [Commented On] D4542: Fix crash with Memory Viewer enabled

[Morten Volden]

volden added a comment.


  In https://phabricator.kde.org/D4542#85373, @antonanikin wrote:
  
  > In https://phabricator.kde.org/D4542#85367, @volden wrote:
  >
  > > Aren't we leaking memory views now?
  > >  How about removing the signal and just deleting all memoryViews in MemoryViewWidgets dtor?
  >
  >
  > Hi, Morten. No, we haven't memleaks after the patch because of using `QObject` parent-child  mechanism:
  >
  > `MemoryView* widget = new MemoryView(this); // line 458`
  >
  > The fixed crash was caused by wrong combination of automatic (`QObject` mechanism) and manual (`slotChildDestroyed()`) approaches for memory management.
  
  
  Ah, yes. You're quite right. No need for the list. :-)

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D4542

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop, apol
Cc: volden, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170211/dc0d3fc9/attachment.html>