[Differential] [Request, 6 lines] D4542: Fix crash with Memory Viewer enabled

[Anton Anikin]

antonanikin created this revision.
antonanikin added a reviewer: KDevelop.
antonanikin added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Steps to reproduce (tested on kubuntu 16.04):
  
  1. Set some breakpoint
  2. Run debug
  3. Close Memory View
  4. KDevelop crashed
  
  Or simply run debug without breakpoint and get "hang-up" of KDevelop at the end of debug session.
  
  The problem of crash was in incorrect memory operations - `MemoryViewerWidget` class creates `MemoryView` objects and set them (QObject) parent to self. This leads to situation when connected `MemoryViewerWidget::slotChildDestroyed` method is called *after* finish of `MemoryViewerWidget` destructor.

TEST PLAN
  Tested with with master branch

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4542

AFFECTED FILES
  debuggers/gdb/memviewdlg.cpp
  debuggers/gdb/memviewdlg.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170210/ac6d1b87/attachment.html>