[Differential] [Request, 64 lines] D4541: Fix loading/unloading of GDB plugin

[Anton Anikin]

antonanikin created this revision.
antonanikin added a reviewer: KDevelop.
antonanikin added a subscriber: kdevelop-devel.

REVISION SUMMARY
  The patch fixes some wrong moments for GDB plugin loading/unloading. The problems are:
  
  1. If the plugin was loaded and we do unload + load, then memory leaks will happens (GdbLauncher objects).
  2. If the plugin was loaded and we do unload, then we still will see it's config page in the launcher configuration.
  3. If we do unload + load for some plugin with "IExecutePlugin" extension, then the GDB plugin will not create new GdbLauncher objects.
  
  The new version fixes all this issues.
  
  After review this approach should be also applied to LLDB plugin.

TEST PLAN
  tested with master branch

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4541

AFFECTED FILES
  debuggers/gdb/debuggerplugin.cpp
  debuggers/gdb/debuggerplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: antonanikin, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170210/31f0de6f/attachment.html>