[Differential] [Requested Changes To] D4411: UnknownDeclarationProblem: scan headers on a background thread to preserve GUI responsiveness (WIP)

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a reviewer: mwolff.
mwolff added a comment.
This revision now requires changes to proceed.


  sorry, but nested eventloops are a no-go.
  
  the api has to be restructured to allow async assistants. until that is not done, shoehorning it in this way is a clear -2 from my side

INLINE COMMENTS

> unknowndeclarationproblem.cpp:71
>  
> +static bool interrupted = false;
> +

probably needs to be atomic? and try to push it into one of the classes

> unknowndeclarationproblem.cpp:73
> +
> +class UDPScanEventLoop : public QEventLoop
> +{

what is UDP?

> unknowndeclarationproblem.cpp:270
>  
> +#if 0
> +    QCoreApplication::sendPostedEvents();

?? remove

> unknowndeclarationproblem.cpp:754
> +    interrupted = false;
> +    UDPScanEventLoop eventLoop;
> +    ClangFixits unknownDeclFixits;

nested eventloops are a no-go

> unknowndeclarationproblem.cpp:758
> +    UDPWorkerThread::connect(scanThread, &UDPWorkerThread::finished, scanThread, &QObject::deleteLater);
> +#if 0
> +    unknownDeclFixits = scanThread->fixUnknownDeclaration();

?? remove

REPOSITORY
  R782 KDevelop Clang Integration

REVISION DETAIL
  https://phabricator.kde.org/D4411

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rjvbb, #kdevelop, mwolff
Cc: mwolff, kdevelop-devel, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170202/87893da1/attachment.html>