D9472: Format comments before setting them on the DUChain

Milian Wolff noreply at phabricator.kde.org
Thu Dec 21 23:22:00 UTC 2017


mwolff created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  This removes the /// and /* ... */ prefixes. Not only does this
  make the stuff way more readable, it also fixes our JSON tests...
  
  Return proper non-C++ specific includes/defines for non-project files
  
  When we query the includes/defines for a file outside of any project
  we always returned the C++ compiler includes/defines. This was because
  we never tried to guess the language type then, since we operated only
  on ProjectBaseItems pointers which are obviously nullptr for files
  outside of any project. Instead, operate on QString path
  representations like elsewhere in the IADM already. This allows us to
  guess the language type even for C, ObjC and Cuda files when they are
  not part of a project.
  
  No unit test is added, but I found this while working on a separate
  feature that has a proper unit test attached.
  
  Handle _Complex types
  
  We just create a delayed type that holds the string representation.
  This is enough to get the type displayed in the tooltips and it also
  removes the pesky warnings from the command line about unhandled
  types.

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9472

AFFECTED FILES
  plugins/clang/duchain/builder.cpp
  plugins/clang/tests/files/purec.c
  plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
  plugins/custom-definesandincludes/compilerprovider/compilerprovider.h
  plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
  plugins/custom-definesandincludes/compilerprovider/settingsmanager.h
  plugins/custom-definesandincludes/definesandincludesmanager.cpp
  plugins/custom-definesandincludes/idefinesandincludesmanager.h

To: mwolff
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171221/0b1086a8/attachment.html>


More information about the KDevelop-devel mailing list