D9210: Remove unused persistentsetmap.h
Kevin Funk
noreply at phabricator.kde.org
Tue Dec 19 22:36:01 UTC 2017
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D9210#176407, @kossebau wrote:
> In https://phabricator.kde.org/D9210#176395, @mwolff wrote:
>
> > this was used by oldcpp, and we could (should!) actually leverage this by kdev-clang to store more information about the parsing environment, such that we can later check whether it has changed and also show the user what was used. That said, maybe persisting a simple vector of strings is enough for that purpose...
>
>
> Was that in some branch? Grepping with gitk in changes on the kdevelop repo did not have any hits, neither "PersistentSetMap" nor "persistentsetmap.h" (besides the introducing commit itself).
Agreed. I can't find code that use this class either.
Maybe indeed remove? We can start over -- it's not like anyone still understands this code anyway, anymore.
REPOSITORY
R32 KDevelop
BRANCH
removeunusedpersistentsetmap
REVISION DETAIL
https://phabricator.kde.org/D9210
To: kossebau, #kdevelop, kfunk
Cc: kfunk, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171219/5e267aa2/attachment-0001.html>
More information about the KDevelop-devel
mailing list