D9344: [KDevelop] : consistent use of the project name (WIP!)

[René J.V. Bertin]

rjvbb created this revision.
rjvbb added a project: KDevelop.

REVISION SUMMARY
  This is a WIP aiming to make KDevelop use the user-specified project name consistently and throughout.
  
  Currently, that name is used only in a few places, the projects toolview and in the titlebar. In all other places where projects are listed by *a* name, the project file name is used which isn't always enough. QMake-based projects in particular will often show up with an ambiguous name like "src" (qtbase, qttools, qtwhatever components imported as projects; their toplevel .pro files don't support that).
  
  Ideally, the user-selected project name should also be used
  
  - to name the .kdev4 project files
  - in the output of kdevelop -l and kdevelop --ps
  
  This will remove any ambiguity that could arise from seeing projects listed by their directory name. It will also make it possible to have multiple projects defined for a single source tree (e.g. for separate components in different subfolders, for building mutually-exclusive Qt4, Qt5 or GTk variants, etc.)
  
  It is currently already possible to achieve this goal by renaming and editing  the generated .kdev4 files (after closing/unloading the corresponding project).
  
  ---
  
  The current patch is just the first step: generating the project file name with minimal code/API changes. It can be used "as is" but then the "override or use existing file?" dialog will pop up when the project is closed and reloaded.
  
  BUG: 384955

TEST PLAN
  - figure out how to integrate the new naming with the code that puts up the "override/use existing" dialog (`equalProjectFile()` called by `ProjectDialogProvider::askProjectConfigLocation()`)
  - nothing should change if the user selects the predetermined project name; verify if this is indeed the case (esp. for the QMake proj. manager)
  - check what happens with projects that have different project filename and name (e.g. `src.kdev4` for a project called `qtbase`).

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D9344

AFFECTED FILES
  kdevplatform/shell/openprojectdialog.cpp

To: rjvbb
Cc: kdevelop-devel, vbspam, njensen, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171215/0a871709/attachment.html>