D9159: Mark more classes & structs as Q_MOVABLE_TYPE/Q_PRIMITIVE_TYPE
Kevin Funk
noreply at phabricator.kde.org
Wed Dec 13 18:05:09 UTC 2017
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Minor issues, rest LGTM.
INLINE COMMENTS
> projectbuildsetmodel.h:93
> +Q_DECLARE_TYPEINFO(KDevelop::BuildItem, Q_MOVABLE_TYPE);
> +Q_DECLARE_TYPEINFO(KDevelop::ProjectBuildSetModel, Q_MOVABLE_TYPE);
> +
This one doesn't really make sense, no? `ProjectBuildSetModel` is a pointer based type and is not meant to be used as container value type.
REPOSITORY
R32 KDevelop
BRANCH
moretypeinfo
REVISION DETAIL
https://phabricator.kde.org/D9159
To: kossebau, #kdevelop, kfunk
Cc: kfunk, mwolff, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171213/2db2519b/attachment.html>
More information about the KDevelop-devel
mailing list