D9160: QList -> QVector where sizeof(T) > sizeof(void*)

Milian Wolff noreply at phabricator.kde.org
Tue Dec 5 10:32:44 UTC 2017


mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  OK, thanks for the clarification. I'm OK with this change, but can you make sure (with clazy?) whether all custom types are properly `Q_DECLARE_TYPEINFO`d?

INLINE COMMENTS

> test_quickopen.cpp:95
>  {
> -    QFETCH(QStringList, items);
> +    using StringVector = QVector<QString>;
> +

define it once at global scope and use it everywhere

REPOSITORY
  R32 KDevelop

BRANCH
  vectorreview

REVISION DETAIL
  https://phabricator.kde.org/D9160

To: kossebau, #kdevelop, mwolff
Cc: mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20171205/ba0c9800/attachment.html>


More information about the KDevelop-devel mailing list