D7554: Outoutview CmakeMultiline expression accidentally hits on CMake Error
noreply at phabricator.kde.org
Mon Aug 28 07:25:35 UTC 2017
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Could you make sure that works on Windows as well? To match Windows-style paths with drive letters?
We have something like this for the compiler filtering strategy:
ErrorFormat( QStringLiteral("^([a-zA-Z]:\\\\.+)\\(([1-9][0-9]*)\\): ((?:error|warning) .+\\:).*$"), 1, 2, 3 ),
(You could easily implementing the feature by adding another #ifdef'fed path for CMake, and remove the #ifdef temporarily to test on a Unix system).
You dont' need to if you don't have the time to.
Patch looks good to me.
To: volden, #kdevelop, kfunk
Cc: kfunk, kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel