D7219: Add separate interface library KDev::Execute for execute/iexecuteplugin.h
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Wed Aug 9 18:40:05 UTC 2017
kossebau added a comment.
In https://phabricator.kde.org/D7219#134137, @kfunk wrote:
> Rest LGTM,
> This is pretty similar to what we did to `IMakeBuilder` before.
Ah, had not seen, okay, so following a pattern :) Makes me wonder if KDevPlatformExecute then should get some target export, as well right? And perhaps then be named KDevPlatformIExecute (_I_), to indicate the interface as well here?
> kfunk wrote in CMakeLists.txt:32
> KDevPlatformShellExecute -> KDevPlatformExecute?
Sure, was a copy, paste & bad-adapt error, should be KDevPlatformExecute, fixed.
To: kossebau, #kdevelop
Cc: kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel