D7217: Separate private macro into KDevPlatformMacrosPrivate

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Also
  
  - add dox for KDEVPLATFORM_ADD_PLUGIN
  - revert "Do not use $<BUILD_INTERFACE> in installed KDevPlatformMacros.cmake"
  
  Motivation for https://phabricator.kde.org/R32:e32618d64ac4fadbdceb228326df63cfac4b8bc8 was that
  kdevplatform_add_library seemed part of public macross, so same like
  kdevplatform_add_plugin, due to being in installed & exported macros file.
  Though with KDevPlatform_SOURCE_DIR & KDevPlatform_BINARY_DIR not
  defined when the macro is imported in other projects, such $<BUILD_INTERFACE>
  would be bogus.
  
  Looking again, KDEVPLATFORM_VERSION & KDEVPLATFORM_LIB_SOVERSION would
  also not be defined. And actually this macro might not be meant for
  public consumption, given that a platform usually is defined by
  a given set of libs, so 3rd-party libs should not want to use this macro
  anyway. So moving the macro out of the installed macro file makes this
  clear and prevents abuse.

REPOSITORY
  R32 KDevelop

BRANCH
  makeaddlibrarymacroprivate

REVISION DETAIL
  https://phabricator.kde.org/D7217

AFFECTED FILES
  CMakeLists.txt
  kdevplatform/CMakeLists.txt
  kdevplatform/cmake/modules/KDevPlatformMacros.cmake
  kdevplatform/cmake/modules/KDevPlatformMacrosPrivate.cmake

To: kossebau, #kdevelop, apol
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170809/5c0fafd4/attachment.html>