D6060: platform-specific document switcher default shortcuts (WIP)

[Friedrich W. H. Kossebau]

kossebau added a comment.


  From the description it seems you are planning more work on this (i.e. finding out why Control+Tab shortcuts are eaten somewhere)?
  Could you please tag this as "Changes planned" then? The informal [WIP] is good, using the system understood flag better :)
  
  No idea about the Mac shortcuts, the non-Mac code looks fine to me so far ;)

INLINE COMMENTS

> documentswitcherplugin.cpp:69
> +    // attribute is set.
> +    Qt::Modifier shortcutAccelerator = QCoreApplication::testAttribute(Qt::AA_MacDontSwapCtrlAndMeta) ? Qt::CTRL : Qt::ALT;
> +#else

Make both shortcutAccelerator const.

REPOSITORY
  R33 KDevPlatform

REVISION DETAIL
  https://phabricator.kde.org/D6060

To: rjvbb, #kdevelop
Cc: kossebau, kdevelop-devel, kde-mac, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170806/354eeea5/attachment.html>