D7128: backgroundparser: Ensure jobs are finished on exit

Kevin Funk noreply at phabricator.kde.org
Fri Aug 4 12:16:04 UTC 2017


kfunk created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  Make sure all parse jobs are done *before* potentially starting to unload language plugins.
  I think this fixes one cause of bug 379669.
  
  With this patch I also fix an assert which I added earlier today; which
  triggers when exiting KDevelop:
  
  Log excerpt:
  
    kdevelop(21550)/kdevplatform.shell:
    KDevelop::PluginController::unloadPlugin(442): unloading plugin:
    ManPagePlugin(0x606001ae16c0) "Man Pages"
    kdevelop(21550)/kdevplatform.documentation:
    DocumentationView::showDocumentation(187): showing "CMake Content Page"
    kdevelop(21550)/kdevplatform.language:
    KDevelop::TypeSystem::ensureFactoryLoaded(64): Factory for this type not
    loaded: 18
    kdevelop(21550)/default: unknown(0): ASSERT: "false" in file
    /home/kfunk/devel/src/kf5/kdevplatform-stable/language/duchain/types/typeregister.cpp,
    line 65
  
  CCBUG: 379669

REPOSITORY
  R33 KDevPlatform

BRANCH
  5.1

REVISION DETAIL
  https://phabricator.kde.org/D7128

AFFECTED FILES
  language/backgroundparser/backgroundparser.cpp
  language/backgroundparser/backgroundparser.h
  shell/core.cpp

To: kfunk
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170804/e7588be4/attachment.html>


More information about the KDevelop-devel mailing list