D7061: Improve search in documentation view: kate-look, hide on ESC, live search
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Wed Aug 2 08:01:56 UTC 2017
kossebau added a comment.
In https://phabricator.kde.org/D7061#131226, @igorkushnir wrote:
> There is a similar simpler review request here: https://git.reviewboard.kde.org/r/126856/diff/3#index_header
> It was already reviewed by Milian Wolff. Feel free to pick anything useful from the old review diff into this one.
Ah, that's a shame that review request had been ignored since. Seems the last version of that patch pretty much is covered by the patch here, just that this here drops the texts from the searchbar toolbuttons, given they have no use if an icon is set and a tooltip. So good to know we agree basically about what would be an improvement :)
The placeholder text might be worth to copy over, though Kate seems to have none (though Firefox has some). Undecided right now :)
To: kossebau, #kdevelop
Cc: igorkushnir, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel