D6838: Fix duplicated annotation context menus & entries on repeated border show

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Aug 1 16:30:10 UTC 2017

kossebau marked an inline comment as done.
kossebau added a comment.

  Thanks for review.
  Just found though that  the approach in this patch for handling the model leakage ignores the case of multiple views on the same document (e.g. as used with projects where lots of classes are in a single long file) and where multiple views have annotation border visible and thus need the annotation model. Simply always deleting the model on hiding the border in one view will steal it from the other views then, not good.
  So dropping the model leak deletion from this patch, needs more thought, and committing the rest, to fix at least the duplicated menu entries.

  R33 KDevPlatform



To: kossebau, #kdevelop, brauch
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170801/b9691ec2/attachment.html>

More information about the KDevelop-devel mailing list