D5666: Default to disabled debug log on Q_LOGGING_CATEGORY calls

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Sun Apr 30 13:46:27 UTC 2017


kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  This removes the need to call QLoggingCategory::setFilterRules()
  in the program code to default to disabled debug type log
  without any other settings. 
  The latter has disadvantages, as it shadows any settings done
  in qtlogging.ini config files by the user
  (e.g. via kdebugsettings), thus enabling runtime control only
  via QT_LOGGING_CONF/QT_LOGGING_RULES, which is not that
  comfortable with lots of categories.
  
  Also use ECMQtDeclareLoggingCategory for less manual code
  
  While there can be some inconsistency with the default disabled
  log categories by ECMQtDeclareLoggingCategory, which
  switched to QtInfoMsg for ECM 5.26 (when KF5 5.26 has Qt 5.5
  as min dep, which is the Qt version QtInfoMsg was added),
  current KDevPlatform code has Qt 5.4 as minimum version and
  thus also does not use qCInfo, so KDevPlatform behaviour should
  be the same across used Qt versions.

REPOSITORY
  R33 KDevPlatform

BRANCH
  useECMQtDeclareLoggingCategory

REVISION DETAIL
  https://phabricator.kde.org/D5666

AFFECTED FILES
  CMakeLists.txt
  debugger/CMakeLists.txt
  debugger/util/debug.cpp
  debugger/util/debug.h
  documentation/CMakeLists.txt
  documentation/debug.h
  documentation/documentationview.cpp
  language/CMakeLists.txt
  language/util/debug.cpp
  language/util/debug.h
  outputview/CMakeLists.txt
  outputview/debug.h
  outputview/ioutputview.cpp
  project/debug.cpp
  serialization/CMakeLists.txt
  serialization/debug.cpp
  serialization/debug.h
  shell/CMakeLists.txt
  shell/debug.cpp
  shell/debug.h
  shell/progresswidget/progressmanager.cpp
  shell/settings/environmentwidget.cpp
  shell/settings/pluginpreferences.cpp
  shell/settings/sourceformattersettings.cpp
  shell/workingsets/closedworkingsetswidget.cpp
  shell/workingsets/workingset.cpp
  shell/workingsets/workingsetwidget.cpp
  sublime/CMakeLists.txt
  sublime/mainwindow.cpp
  sublime/sublimedebug.h
  util/CMakeLists.txt
  util/debug.cpp
  util/debug.h
  vcs/CMakeLists.txt
  vcs/debug.cpp
  vcs/debug.h
  vcs/dvcs/dvcsjob.cpp
  vcs/dvcs/ui/branchmanager.cpp
  vcs/models/brancheslistmodel.cpp
  vcs/widgets/vcsdiffpatchsources.cpp
  vcs/widgets/vcsdiffwidget.cpp
  vcs/widgets/vcseventwidget.cpp

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170430/8b88972d/attachment.html>


More information about the KDevelop-devel mailing list