D5604: Remove Q_SCRIPTABLE tags not used for D-Bus or QML (no more Kross support)
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Wed Apr 26 16:49:14 UTC 2017
kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.
REVISION SUMMARY
There were lots of Q_SCRIPTABLE tags which once were added for Kross,
but no longer serve any purpose, besides a few being picked up/reused
for interfaces exposed to QML or D-Bus.
This patch removes any such tags which were not used or useful (due
to incomplete types) from QML and D-Bus.
For access to KDevelop::ICore's projectController from QML instead
a QObject property is now noted. And the methods of IProjectController
used from QML are tagged as Q_INVOKABLE, so they are not included
in the D-Bus interface.
It will also remove the console warnings during start-up
"
Invalid return type in method "core"
"
which are from method generateInterfaceXml(...) in
qtbase/src/dbus/qdbusxmlgenerator.cpp when it generates
the interface for ExternalScriptPlugin, which inherits
KDevelop::IPlugin, which had its method
ICore *core() const; tagged with Q_SCRIPTABLE,
and as the ExternalScriptPlugin registers itself as
object to the bus using QDBusConnection::ExportScriptableSlots
that method was included in the interface, but without ICore*
being known.
REPOSITORY
R33 KDevPlatform
BRANCH
cleanupQ_SCRIPTABLE
REVISION DETAIL
https://phabricator.kde.org/D5604
AFFECTED FILES
interfaces/icompletionsettings.h
interfaces/icore.h
interfaces/idocumentcontroller.h
interfaces/ilanguagecontroller.h
interfaces/iplugin.h
interfaces/iplugincontroller.h
interfaces/iproject.h
interfaces/iprojectcontroller.h
interfaces/iruncontroller.h
language/backgroundparser/backgroundparser.h
language/backgroundparser/parsejob.h
language/duchain/duchain.h
plugins/welcomepage/qml/Develop.qml
plugins/welcomepage/qml/plugins/Branches.qml
plugins/welcomepage/qml/plugins/Projects.qml
shell/documentcontroller.h
shell/languagecontroller.h
To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170426/80837e0a/attachment.html>
More information about the KDevelop-devel
mailing list