D5536: Appwizard: fix broken disconnect in ProjectVcsPage

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  The disconnect was broken since it was added:
  
    disconnect( this, SLOT(validateData()) );
  
  (added in https://phabricator.kde.org/R33:9f46f693e743ad84032c7e820c61f2e45fc630e2)
  which will call
  
    QObject::disconnect(const QObject *receiver, const char *method)
    "Disconnects all signals in this object from receiver's method."
  
  and thus not do what has been intended, to disconnect from the signal
  of the previous importWidget.
  The port to new signal/slot syntax did not improve the wrong logic
  even if the very disconnect call was discussed for other reasons
  in the review :)
  (see commit https://phabricator.kde.org/R33:f626743803ab900038890b04b5613b871d2c7ee1 and
  https://git.reviewboard.kde.org/r/121045)
  
  As it seems needed to track the current import widget, to know whose
  signal to disconnect from, the new member m_currentImportWidget
  can be also used to drop code for dynamic lookup of that widget
  in some the property access methods of ProjectVcsPage.
  (will be a separate commit)
  
  The broken disconnect did not result in a real bug from what I saw,
  but still added noise in the debug log, so one reason to fix it.
  
  Target: 5.1

REPOSITORY
  R33 KDevPlatform

BRANCH
  fixbrokendisconnect

REVISION DETAIL
  https://phabricator.kde.org/D5536

AFFECTED FILES
  plugins/appwizard/projectvcspage.cpp
  plugins/appwizard/projectvcspage.h

To: kossebau, #kdevelop
Cc: kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170421/6954b3f9/attachment.html>