D5533: Use openDeclaration(Identifier) in QMLJS plugin

[Nicolás Alvarez]

nalvarez created this revision.
nalvarez added a project: KDevelop.
Restricted Application added a subscriber: kdevelop-devel.

REVISION SUMMARY
  As discussed on the mailing list, `AbstractDeclarationBuilder::openDeclaration(QualifiedIdentifier)` makes little sense semantically. I added an overload taking an `Identifier`, with the intention of deprecating and removing the QID overload in the future.
  
  This commit makes the QMLJS plugin use the `openDeclaration(Identifier)` overload everywhere.
  
  Since I made a lot of code use `Identifier` directly, I had to add a few conversions to `QualifiedIdentifier` in order to pass it to `openContext`. Ideally `openContext` should take an `Identifier` too, but that's harder to change (I posted a separate thread in the mailing list about it).

TEST PLAN
  Compiled, ran unit tests. The tests don't actually pass due to unrelated problems (eg. https://phabricator.kde.org/R33:76765692538d3af40374b0c9ae63eb6eb41c53c0), but the failures are exactly the same as without this commit.

REPOSITORY
  R32 KDevelop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5533

AFFECTED FILES
  languages/qmljs/duchain/declarationbuilder.cpp
  languages/qmljs/duchain/declarationbuilder.h
  languages/qmljs/duchain/frameworks/nodejs.cpp

To: nalvarez
Cc: kdevelop-devel, geetamc, Pilzschaf, akshaydeo, surgenight, arrowdodger
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170421/45b392de/attachment-0001.html>