D5491: Improve detection of builtin defines from compiler command

[Sergey Kalinichev]

skalinichev added inline comments.

INLINE COMMENTS

> gcclikecompiler.cpp:50
> +    QString standardFlag;
> +    QStringList result = arguments;
> +    for (int i = 0; i < arguments.size(); ++i) {

Does it mean that now we provide arguments like "-ferror-limit=100 -fspell-checking -Wdocumentation" to the compiler?

It won't work with gcc and old clang versions

> test_compilerprovider.cpp:417
> +    if (!m_clang) {
> +        QSKIP("Test requires a Clang compiler");
> +    }

Please, add tests for gcc too. Ideally all test should work equally well with clang/gcc

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D5491

To: arichardson, #kdevelop, kfunk, mwolff
Cc: skalinichev, aaronpuchert, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170420/1c57101f/attachment.html>