D5447: Only add auto-detected compilers to model if they actually exist

Sergey Kalinichev noreply at phabricator.kde.org
Tue Apr 18 17:35:15 UTC 2017


skalinichev added inline comments.

INLINE COMMENTS

> compilerfactories.cpp:44-46
> +    const QString clang = QStandardPaths::findExecutable(QStringLiteral("clang"));
>  
> +    if (!clang.isEmpty()) {

It doesn't seem right, we already perform that check in CompilerProvider::CompilerProvider

REPOSITORY
  R32 KDevelop

BRANCH
  extra-args

REVISION DETAIL
  https://phabricator.kde.org/D5447

To: arichardson, mwolff, kfunk
Cc: skalinichev, apol, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170418/c8d0b384/attachment.html>


More information about the KDevelop-devel mailing list