D5183: Reopen accidentally closed tab

[Alexander Basov]

coopht added a comment.


  In https://phabricator.kde.org/D5183#98731, @apol wrote:
  
  > In https://phabricator.kde.org/D5183#98625, @coopht wrote:
  >
  > > In https://phabricator.kde.org/D5183#98623, @apol wrote:
  > >
  > > > Wouldn't it make sense to implement it somewhere separate as an observer rather than making the current sublime/container class even bigger?
  > >
  > >
  > > I don't think that these changes making sublime/container much bigger. This is a pretty small changes and the idea is to track closed files for each container.
  > >  What is the proper place to implement it as an observer?
  >
  >
  > You could add a ReopenAction class. Either in Sublime or the shell.
  
  
  I moved it to ReopenAction.
  If ReopenAction is used in shell/MainWindow or sublime/MainWindow than it become more complicated to maintain separate lists of recently closed files for each view.
  I suggest to use ReopenAction in the container, to simplify support of separate views for each view.
  I tried to minimize my changes to the containe class.

REVISION DETAIL
  https://phabricator.kde.org/D5183

To: coopht, mwolff, #kdevelop
Cc: apol, kossebau, mwolff, brauch, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20170407/2b3f65f5/attachment.html>