Review Request 128943: Report man pages loading error

[Igor Kushnir]

> On Sept. 19, 2016, 10:37 a.m., Aleix Pol Gonzalez wrote:
> > Ship It!
> 
> Aleix Pol Gonzalez wrote:
>     Do you have commit rights?

No, I do not.
I haven't contributed to KDE much yet.


- Igor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128943/#review99273
-----------------------------------------------------------


On Sept. 19, 2016, 8:56 a.m., Igor Kushnir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128943/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 8:56 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> If kio-extras is not installed, Man page loading progress bar is stuck at zero.
> Showing an error message helps to identify the problem and fix it.
> 
> 
> Diffs
> -----
> 
>   documentation/manpage/manpagedocumentationwidget.h 745f2bd2b4c3319567b866ccb5f82e113261f975 
>   documentation/manpage/manpagedocumentationwidget.cpp c76827c24101b8aba96111e38114114806a727b9 
>   documentation/manpage/manpagemodel.h 054eb80c37ac9095808907931f5dd15fdabd7f16 
>   documentation/manpage/manpagemodel.cpp 98bbf4f96f2239006b311aa65260babf04997b07 
> 
> Diff: https://git.reviewboard.kde.org/r/128943/diff/
> 
> 
> Testing
> -------
> 
> Built, installed, run test_manpagemodel.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot before this change
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/19/18414309-8d62-4437-a974-b53ececce085__before-this-commit-no-kio-extras.png
> Screenshot after this change
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/19/592b1837-bb51-4eb1-b0af-94a499b414eb__after-this-commit-no-kio-extras.png
> Screenshot before/after this change with kio-extras installed
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/19/fa6797bb-c374-492c-b19c-a67029c64126__before-or-after-this-commit-with-kio-extras.png
> 
> 
> Thanks,
> 
> Igor Kushnir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160919/dced7a79/attachment.html>