[Differential] [Accepted] D2765: clang: Make sure include paths are unique
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Wed Sep 14 08:07:32 UTC 2016
kfunk accepted this revision.
kfunk added a reviewer: kfunk.
kfunk added a comment.
This revision is now accepted and ready to land.
Makes sense to me. The order of the include paths is not really relevant for the include path completion.
Please check if this change does not break unit tests.
INLINE COMMENTS
> includepathcompletioncontext.cpp:168
> if (properties.local) {
> paths.push_front(Path(url).parent());
> }
Performance: If we sort paths later on, pushing to front makes no sense. Can push to the end here.
REPOSITORY
rKDEVELOP KDevelop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2765
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: aspotashev, mwolff, kfunk
Cc: brauch, kfunk, kdevelop-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20160914/4044ed49/attachment.html>
More information about the KDevelop-devel
mailing list